From 64a14f117058ea7c3443815fa672071836c2267a Mon Sep 17 00:00:00 2001 From: Phil Snyder Date: Thu, 14 Nov 2024 11:40:22 -0800 Subject: [PATCH] upgrade to v2 of ecr login action --- .github/workflows/upload-and-deploy.yaml | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/.github/workflows/upload-and-deploy.yaml b/.github/workflows/upload-and-deploy.yaml index ea8b877..5110379 100755 --- a/.github/workflows/upload-and-deploy.yaml +++ b/.github/workflows/upload-and-deploy.yaml @@ -192,15 +192,10 @@ jobs: - name: Login to Amazon ECR id: login-ecr - uses: aws-actions/amazon-ecr-login@v1 + uses: aws-actions/amazon-ecr-login@v2 + with: + mask-password: 'false' - - name: Get ECR secret names - id: ecr - run: | - usernameKey=docker_username_$(echo ${{ steps.login-ecr.outputs.registry }} | tr '.-' _) - echo "username-key=$usernameKey" >> $GITHUB_OUTPUT - passwordKey=docker_password_$(echo ${{ steps.login-ecr.outputs.registry }} | tr '.-' _) - echo "password-key=$passwordKey" >> $GITHUB_OUTPUT - uses: actions/checkout@v3 - name: Set up Docker Buildx @@ -217,8 +212,8 @@ jobs: cache-to: type=local,dest=/tmp/.buildx-cache outputs: ecr-registry: ${{ steps.login-ecr.outputs.registry }} - ecr-username: ${{ steps.login-ecr.outputs[steps.ecr.outputs.username-key] }} - ecr-password: ${{ steps.login-ecr.outputs[steps.ecr.outputs.password-key] }} + ecr-username: ${{ steps.login-ecr.outputs['docker_username_' + steps.login-ecr.outputs.registry] }} + ecr-password: ${{ steps.login-ecr.outputs['docker_password_' + steps.login-ecr.outputs.registry] }} glue-unit-tests: name: Run Pytest unit tests for AWS glue