Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change readLength to number? #856

Open
Aryllen opened this issue Aug 13, 2021 · 3 comments
Open

Change readLength to number? #856

Aryllen opened this issue Aug 13, 2021 · 3 comments
Assignees
Labels

Comments

@Aryllen
Copy link
Collaborator

Aryllen commented Aug 13, 2021

Currently, readLength is a string. This seems like it should be a number, though. When using JSON validation, numbers input to a string variable are considered invalid.

Would changing readLength to a string break anything for anyone?

@avanlinden
Copy link
Contributor

@Aryllen We have a lot of contributors provide readLength values that are non-numeric, e.g. "100bp" or "28/56/100" for hashtagged libraries. I haven't been enforcing numeric values because the key is a string, and there are some legacy studies with non-numeric readLength annotations. 😬

I agree it should be numeric, so if we want to change it I could try to edit all the non-numeric values...

@kelshmo
Copy link
Contributor

kelshmo commented Aug 17, 2021

PEC also has non-numeric read lengths like "2x150bp", "300-500bp" etc.

@Aryllen
Copy link
Collaborator Author

Aryllen commented Aug 17, 2021

Okay, that's a tough call. Editing all of those would take time and the hashed or range ones would be an issue still. I'm going to leave this open, but let's leave readLength as a string for now. It could be changed later. Just be aware that the annotation editor in the web will complain if someone tries to annotate with a number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants