Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace inconsistency error not thrown #12

Open
ghost opened this issue Aug 19, 2015 · 1 comment
Open

Whitespace inconsistency error not thrown #12

ghost opened this issue Aug 19, 2015 · 1 comment

Comments

@ghost
Copy link

ghost commented Aug 19, 2015

First off: I love this package, and I've found it incredibly helpful. Thank you guys for your hard work.

This is something I stumbled upon:
Any whitespace inconsistencies will cause the conversion to "complete", but the file with whitespace inconsistencies is not converted, nor are any sibling files in the same directory. I'm using "sass-convert" as part of a gulp task. I ended up running SASS's "sass-convert" command line tool, which threw an error indicating that there was a whitespace inconsistency.

Should this throw an error and end the conversion instead of failing silently?
Or is anyone else having issues recreating this?

@pascalduez
Copy link
Member

Hey,

thanks for the report.
This is indeed a wrong behavior, any error or notice from the sass-convert binary should be caught and printed to the end user. Unconverted files should not be passed through the stream.

nor are any sibling files in the same directory

This is weird.

Anyway, we will need to run some tests and debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant