-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolve #1519] Improve error message #1522
Conversation
for more information, see https://pre-commit.ci
Added mention of potential missing permissions.
for more information, see https://pre-commit.ci
In general I am a bit concerned that while I support the general idea, the implementation here just will not scale to the handling of all exceptions in all places in the code and will not therefore be maintainable. E.g. the PR suggests we handle I wonder if you should start by reviewing this much earlier PR |
I completely agree that this is addressing a narrow case and that a more general solution is needed. I would argue that:
C'mon, it's been forever since I submitted a PR. 😆 |
@dboitnot Here are some more thoughts:
|
Closing in favour of #1530 |
Resolves #1519 by:
PR Checklist
[Resolve #issue-number]
.poetry run tox
) are passing.poetry run pre-commit run --all-files
).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit