-
Notifications
You must be signed in to change notification settings - Fork 84
foreign key creation fails silently with activerecord-postgis-adapter 0.6.5 #120
Comments
Yeah, PostGIS isn't on the "officially supported" list, i.e. it's not in the travis-ci test suite. Maybe it should be? But I'm not familiar with PostGIS myself so not in a good position to dive in and make it work and maintain it. Others have used PostGIS with schema_plus in the past, and have contributed to making it work, as per #94... (@pete are you still out there?) |
I am not familiar with travis-ci, though I did manage to find that the adapter in question is in fact in the suite at:
Is that helpful? |
@ronen I am still out here. ☺ Interesting bug. I'll see if I can slice off some time to investigate today or this week, though I hesitate to make promises. I suspect there's a trivial fix. |
@wrkrb33 thanks, but the issue isn't so much finding the adapter as making it work with schema_plus. and i wasn't clear regarding the test suite: i meant i've not configured schema_plus's travis-ci setup to include postgis, so there's no assurance that schema_plus will continue to work with postgis. in that sense, postgis isn't "officially supported" if somebody out there in github-land was able to
then i'd be ok with pulling it all into schema_plus and thereby "officially" supporting postgis from then on. but i'm unfortunately not in a position to do all that myself, so need to wait for somebody else's good graces... |
@pete hi again! sorry your comment came in while i was in the midst of composing my previous one. FYI i'll probably accept a trivial fix same as with #94, but of course if postgis support is really important then getting it fully tested and in the travis-ci matrix as per my previous comment would be the way to go. i understand no promises though :) |
In a semi-related note, today's Ruby Weekly had a reference to a blog post by Nick Gauthier about using PostGIS with the PostgreSQL adapter (instead of the PostGIS adapter). I'm curious if his approach would work with using schema_plus to handle the expression index. If @pete doesn't get to this in the next week or two, I may take a stab at it (but given that I have no PostGIS experience at all, he's more likely to be successful). |
No foreign key constraint is created with the following migration:
If I change database.yml to use the postgresql adapter instead, then it works as expected.
However, db:schema:dump does dump existing foreign key constraints, regardless of which adapter is used.
The text was updated successfully, but these errors were encountered: