Problems with polymorphic models?

[andreasklinger]

If you use schema_plus together with friendly_id it tries to create foreign_keys for non-existing relations.

PG::UndefinedTable: ERROR:  relation "sluggables" does not exist

Solution is

 t.integer  :sluggable_id,   :null => false, :foreign_key => false

But it feels like this is a bug handling polymorphic relations

More info: norman/friendly_id#552 (comment)

[smudge]

Seeing this as well. This fails:

t.string :resource_id,   null: false
t.string :resource_type, null: false

This works:

t.string :resource_id,   null: false, :foreign_key => false
t.string :resource_type, null: false

A fix might be to recognize the [thing]_id:integer [thing]_type:string pattern and not attempt to create the foreign key. I can't think of anything more accurate since the polymorphic relation is defined in the model class, not in the migration.

[ronen]

@smudge that does seem like a reasonable solution, No time for me to do it myself right now but I'd be happy to accept a PR, should somebody want to code it up. (it should support :foreign_key => yes to force the foreign key anyway.) (and of course should included tests!)