Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Postgres money column type #45

Closed
plicjo opened this issue Nov 16, 2016 · 2 comments
Closed

Support Postgres money column type #45

plicjo opened this issue Nov 16, 2016 · 2 comments

Comments

@plicjo
Copy link
Contributor

plicjo commented Nov 16, 2016

Opened as a result of the discussion in this PR: #44 (comment)

With numeric types things are more complicated, since Postgres has the Money type, for instance, and it looks like it won't be detected as numeric. Then again, the old code might have been wrong too, since it detected Money as numeric, but not as decimal.
...

With the current version of Rails it seems that the only missing type is :money from PostgreSQL which should be mapped to Decimal.

We need to add validation support for the :money column type in PostgreSQL as if it was a decimal column.

@boazy
Copy link
Member

boazy commented Nov 16, 2016

Fixed with 83ba3ab

@boazy
Copy link
Member

boazy commented Nov 16, 2016

I want to write unit tests for that, so I'm reopening a new issue for unit tests, so I've opened a new issue #46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants