You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We decided back then not to translate imports and exports there, because it would represent too much work. The issue is that the imported / exported meta data is static from german, and some conditions in the code rely on them.
The design for this feature involves a complicated refactor, some ideas:
extract the static remaining german into classes where we could "tag" the language selecte, and depending on that, the translation fetched would be different -> the conditions in the code would then apply regardless of the translation string, but apply on that "language-less tags"
This issue has roots at these locations (at least):
For instance, the "Ja" / "Nein" make it impossible to handle without generic values. We might have to change the interface for generic values (true | false) .
Link to design proposal file
No response
The text was updated successfully, but these errors were encountered:
Preflight Checklist
Request type
Request for enhancement of a component
Functionality
Enhancement of the previous translation framework
We decided back then not to translate imports and exports there, because it would represent too much work. The issue is that the imported / exported meta data is static from german, and some conditions in the code rely on them.
The design for this feature involves a complicated refactor, some ideas:
This issue has roots at these locations (at least):
netzgrafik-editor-frontend/src/app/services/data/node.service.ts
Line 1072 in b83f0ec
netzgrafik-editor-frontend/src/app/services/data/node.service.ts
Line 1090 in b8658b7
netzgrafik-editor-frontend/src/app/services/data/node.service.ts
Line 1125 in b8658b7
netzgrafik-editor-frontend/src/app/services/data/node.service.ts
Line 1132 in b8658b7
netzgrafik-editor-frontend/src/app/services/data/version-control.service.ts
Line 90 in b8658b7
netzgrafik-editor-frontend/src/app/view/editor-tools-view-component/editor-tools-view.component.ts
Line 224 in d87b449
For instance, the "Ja" / "Nein" make it impossible to handle without generic values. We might have to change the interface for generic values (
true
|false
) .Link to design proposal file
No response
The text was updated successfully, but these errors were encountered: