Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Translation of imports / exports #197

Open
3 tasks done
louisgreiner opened this issue Jul 25, 2024 · 0 comments
Open
3 tasks done

[Feature request]: Translation of imports / exports #197

louisgreiner opened this issue Jul 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@louisgreiner
Copy link
Collaborator

louisgreiner commented Jul 25, 2024

Preflight Checklist

Request type

Request for enhancement of a component

Functionality

Enhancement of the previous translation framework

We decided back then not to translate imports and exports there, because it would represent too much work. The issue is that the imported / exported meta data is static from german, and some conditions in the code rely on them.

The design for this feature involves a complicated refactor, some ideas:

  • extract the static remaining german into classes where we could "tag" the language selecte, and depending on that, the translation fetched would be different -> the conditions in the code would then apply regardless of the translation string, but apply on that "language-less tags"

This issue has roots at these locations (at least):

For instance, the "Ja" / "Nein" make it impossible to handle without generic values. We might have to change the interface for generic values (true | false) .

Link to design proposal file

No response

@aiAdrian aiAdrian added the enhancement New feature or request label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants