Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pinToStartPage mechanism from Workbench Client Testing App #551

Open
k-genov opened this issue Apr 26, 2024 · 0 comments
Open

Remove pinToStartPage mechanism from Workbench Client Testing App #551

k-genov opened this issue Apr 26, 2024 · 0 comments

Comments

@k-genov
Copy link
Contributor

k-genov commented Apr 26, 2024

Currently, there is a pinToStartPage check box in the Register Capability Microfrontend View, which is only selectable for views and popups but not for dialogs and message boxes. Consider removing the whole mechanism since it only allows opening the microfrontends with default values and it is not possible to parametrize it. E2E Tests using should be migrated to some other simpler mechanism.

danielwiehl added a commit that referenced this issue May 21, 2024
- provide view from host app
- move view to interact with microfrontend platform to host app
- remove test capability mechanism

- consider removing workbench-client handles from host (dialog, message box, popup)
- consider ignoring size set for a message box if provided by the host app
- use actual test app names in register capability and register intention
#271, #551
danielwiehl added a commit that referenced this issue May 21, 2024
- provide view from host app
- move view to interact with microfrontend platform to host app
- remove test capability mechanism

- consider removing workbench-client handles from host (dialog, message box, popup)
- consider ignoring size set for a message box if provided by the host app
- use actual test app names in register capability and register intention
#271, #551
danielwiehl added a commit that referenced this issue May 22, 2024
- provide view from host app
- move view to interact with microfrontend platform to host app
- remove test capability mechanism

- consider removing workbench-client handles from host (dialog, message box, popup)
- consider ignoring size set for a message box if provided by the host app
- use actual test app names in register capability and register intention
#271, #551
danielwiehl added a commit that referenced this issue May 22, 2024
- provide view from host app
- move view to interact with microfrontend platform to host app
- remove test capability mechanism

- consider removing workbench-client handles from host (dialog, message box, popup)
- consider ignoring size set for a message box if provided by the host app
- use actual test app names in register capability and register intention
#271, #551
danielwiehl added a commit that referenced this issue May 22, 2024
- provide view from host app
- move view to interact with microfrontend platform to host app
- remove test capability mechanism

- consider removing workbench-client handles from host (dialog, message box, popup)
- consider ignoring size set for a message box if provided by the host app
- use actual test app names in register capability and register intention
#271, #551
@github-project-automation github-project-automation bot moved this to Triage in SCION Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

No branches or pull requests

1 participant