Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate view if it requires user confirmation before closing (CanClose guard) #558

Open
danielwiehl opened this issue May 16, 2024 · 1 comment
Assignees

Comments

@danielwiehl
Copy link
Collaborator

If multiple views are closed at once (e.g., via ‘Close all tab’) and there are views that prevent closing, e.g., require user confirmation, then views that can be closed without confirmation should be closed immediately, and views that require confirmation should be activated first.

Currently, a view that prevents closing will not be activated, which is confusing for the user because the message box does not relate to the currently activated view.

@Marcarrian
Copy link
Collaborator

No navigation can be performed while the promise of a canClose guard is pending, e.g., when opening a message box with view modality in the guard.

@jmg27dev jmg27dev assigned jmg27dev and unassigned jmg27dev Aug 22, 2024
danielwiehl added a commit that referenced this issue Nov 17, 2024
…h navigation

Previously, a blocking ‘CanClose’ guard prevented any further workbench navigation, for example, activating another view was not possible.

closes #558
danielwiehl added a commit that referenced this issue Nov 17, 2024
…h navigation

Previously, a blocking ‘CanClose’ guard prevented any further workbench navigation, for example, activating another view was not possible.

closes #558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants