Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exceptions instead of using assert #366

Open
bouweandela opened this issue Jun 11, 2024 · 1 comment
Open

Raise exceptions instead of using assert #366

bouweandela opened this issue Jun 11, 2024 · 1 comment

Comments

@bouweandela
Copy link
Member

There are assert statements in various places, e.g.
https://github.com/SciTools-incubator/iris-esmf-regrid/blob/fdd2051dfff050b18c356a2b4277426e74415a61/esmf_regrid/schemes.py#L185-L186

For applications and users of this library, it would be nice to replace those with exceptions with a message explaining the error.
@trexfeathers
Copy link
Contributor

assert (S101) - Ruff (astral.sh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🚴 Peloton
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bouweandela @trexfeathers