New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iris-grib prettier #391

Open

HGWright opened this issue Mar 20, 2024 · 1 comment

Labels

Type: Infrastructure

Contributor

HGWright commented Mar 20, 2024

https://learn.scientific-python.org/development/guides/repo-review/?repo=scitools%2Firis-grib

HGWright added the Type: Infrastructure label

Member

bjlittle commented Apr 4, 2024

@HGWright prettier uses node to do it's formatting, but unfortunately the glibc version on the VDI is too old i.e.,

> ldd --version
ldd (GNU libc) 2.17
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

And prettier seems to need 2.25+

So you might want to skip repo-review compliance with this i.e., instead add the following to the pyproject.toml,

[tool.repo-review]
ignore = [
    # https://learn.scientific-python.org/development/guides/style/#PC180
    "PC180",  # Uses prettier.
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment