Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write GRIB1 loading tests to modern standards #488

Open
Tracked by #56
trexfeathers opened this issue Jun 18, 2024 · 0 comments
Open
Tracked by #56

Write GRIB1 loading tests to modern standards #488

trexfeathers opened this issue Jun 18, 2024 · 0 comments
Labels
Dragon Sub-Task 🦎 https://github.com/orgs/SciTools/projects/19?pane=info

Comments

@trexfeathers
Copy link
Contributor

trexfeathers commented Jun 18, 2024

Iris-grib has been loading GRIB1 for years, so to the best of our knowledge it is loading things correctly in our users' eyes. Write a series of tests that thoroughly assert the current behaviour as the desired behaviour, by examining the loaded Cubes. This is the principle as Assert-CML, if we wanted to go that direction.

This work is required to support #56 - we can make sweeping refactors and know that we have not changed behaviour.

Files to check

$ cd ...git/iris-test-data/test_data/GRIB
$ find . -iname "*.grib1"
./lambert/lambert.grib1
./rotated_uk/uk_wrongparam.grib1
./reduced/reduced_ll_missing.grib1
./reduced/reduced_ll.grib1
./shape_of_earth/global.grib1
./time_processed/time_bound.grib1
./gaussian/regular_gg.grib1

Possible implementations

  • AssertCML
  • Cube equality against saved NetCDF Cubes
  • Many specific asserts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dragon Sub-Task 🦎 https://github.com/orgs/SciTools/projects/19?pane=info
Projects
Status: No status
Development

No branches or pull requests

1 participant