Enumeration String no longer supports certain characters

[byeblack]

Description

Create an enumeration, an error proc-macro derive panicked message: "" occurs when inputting most non-English languages as its value.

Steps to Reproduce

1. Add SeaORM version 0.12.0 or above to the project.
2. Use the command sea-orm-cli generate entity -u sqlite://any.sqlite to create any entity.
3. Add an enumeration to the created table and use a non-English language as its value.

Expected Behavior

The enumeration should be able to handle all supported characters without any errors.

Actual Behavior

An error occurs when most non-English languages are used as the enumeration value: proc-macro derive panicked message: "".

Reproduces How Often

The issue is consistently reproducible.

Workarounds

No workaround has been identified yet.

Reproducible Example

Please refer to this example link: Reproducible Example

#[derive(Clone, Debug, PartialEq, Eq, EnumIter, DeriveActiveEnum)]
#[sea_orm(rs_type = "String", db_type = "String(None)", enum_name = "status")]
pub enum Status {
    // #[sea_orm(string_value = "Open")]
    // #[sea_orm(string_value = "열려 있는")]

    // The following situations
    // proc-macro derive panicked message: `""` is not a valid identifier
    #[sea_orm(string_value = "打开")]
    // #[sea_orm(string_value = "開ける")]
    // #[sea_orm(string_value = "Нээлттэй")]
    // #[sea_orm(string_value = "Открыть")]
    // #[sea_orm(string_value = "يفتح")]
    Open,
    #[sea_orm(string_value = "Close")]
    Close,
}

Versions

SeaORM version: 0.12.0 and above.

[tyt2y3]

I am not sure, but it seems the error originate from within the derive macro, may be related to the upgrade to syn2?

[iam888]

SeaORM version 0.12.15,

proc-macro derive panicked
message: `""` is not a valid identifier

code:

//! `SeaORM` Entity. Generated by sea-orm-codegen 0.11.0

use sea_orm::entity::prelude::*;

#[derive(Debug, Clone, PartialEq, Eq, EnumIter, DeriveActiveEnum)]
#[sea_orm(rs_type = "String", db_type = "Enum", enum_name = "cate")]
pub enum Cate {
    #[sea_orm(string_value = "開ける")]
    開ける,
}

[ghsang]

@tyt2y3 Could you reopen this issue? It is still not working on 0.12.15

[tyt2y3]

can you open a PR to submit a failing test case? @ghsang

[byeblack]

I've updated the examples to 0.12.15 Reproducible Example
It still has the same problem.

can you open a PR to submit a failing test case? @ghsang

[byeblack]

Hello, @tyt2y3. I'm pretty confident I've just found the source of the error in the master branch. It's occurring in sea-orm-macros\src\derives\active_enum.rs:

...
            let enum_variant_iden = format_ident!("{}Variant", ident);
            let enum_variants: Vec<syn::Ident> = str_variants
                .iter()
                .map(|v| {
                    let v_cleaned = camel_case_with_escaped_non_uax31(v); // It turns the string into empty

                    format_ident!("{}", v_cleaned) // Error occurs here
                })
                .collect();
...

When I bypass camel_case_with_escaped_non_uax31(v), the following example can run smoothly for insertions, queries, and filtered queries. However, I'm not confident in my ability to fix it. I would greatly appreciate it if you could resolve this issue.

#[derive(Clone, Debug, PartialEq, Eq, EnumIter, DeriveActiveEnum)]
#[sea_orm(rs_type = "String", db_type = "Enum", enum_name = "status")]
pub enum Status {
    #[sea_orm(string_value = "Open")]
    Open,
    #[sea_orm(string_value = "열려_있는")]
    열려있는,
    #[sea_orm(string_value = "打开")]
    打开,
    #[sea_orm(string_value = "開ける")]
    開ける,
    #[sea_orm(string_value = "Нээлттэй")]
    Нээлттэй,
    #[sea_orm(string_value = "Открыть")]
    Открыть,
    #[sea_orm(string_value = "يفتح")]
    يفتح,
    #[sea_orm(string_value = "Close")]
    Close,
}

Reproducible Example

[ghsang]

@tyt2y3 I have opened a PR with a fix and a test case.