Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPlatformTest>>supportsUnicode should be moved to the GRPlatform #175

Closed
eMaringolo opened this issue Apr 10, 2024 · 1 comment
Closed

Comments

@eMaringolo
Copy link

The current implementation in GRPlatformTest attempts to guess whether the Smalltalk dialect supports Unicode, but it raises an exception in platforms such as VAST where it does support it but not by using Characters with codepoints greater than 255 (e.g. VAST uses a Grapheme class for that).

Te guesswork could remain, but it should be moved to the platform specific class, so we don't have to patch that code in the original codebase and we can determine whether we support it in our own packages.

supportsUnicode
	"dynamically try to figure out whether the current dialect supports Unicode"
	^ [ 
		String
			with: (Character value: 16r1F1F3)
			with: (Character value: 16r1F1F1).
		true
	 ] on: Error do: [ :error | false ]
@jbrichau
Copy link
Member

Addressed in #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants