Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row height seems to be broken in 3.0 #368

Open
trinhanhngoc opened this issue Nov 14, 2022 · 7 comments
Open

Row height seems to be broken in 3.0 #368

trinhanhngoc opened this issue Nov 14, 2022 · 7 comments
Assignees

Comments

@trinhanhngoc
Copy link

After installing the latest version 3.0.1 on PyCharm 2022.23 (Mac OS), row height in table editor is too small, default row height in Settings has no effect.

image

image

@SeeSharpSoft
Copy link
Owner

Both, row height and column width defaults, are measured in px. I will add the unit to the settings.

Furthermore, in the table editor the row height can be adjusted by dragging the row lines on the left side (row counts), similar to changing the column width.

@trinhanhngoc
Copy link
Author

@SeeSharpSoft Thank for the info. Another question: How to reset row height value in a file to the default value in setting?

@SeeSharpSoft
Copy link
Owner

Update: I just noticed that the previous row height setting might be taken into account, which was not the row height in px but but the number of row lines. I will fix this.

@SeeSharpSoft
Copy link
Owner

How to reset row height value in a file to the default value in setting?

There is no option for this, but it should be quite uncomplicated to adjust the row height for a file manually to your likings. The default value is 48px (usually like 2 row lines).

@trinhanhngoc
Copy link
Author

How to reset row height value in a file to the default value in setting?

There is no option for this, but it should be quite uncomplicated to adjust the row height for a file manually to your likings. The default value is 48px (usually like 2 row lines).

Ok. Thank you very much!. My plugin depends on your plugin for some features in CSV files. I plan to do some PRs for your plugin to make the integration better for features like code completion, reference navigation,... I hope you accept it.

@SeeSharpSoft
Copy link
Owner

Sounds good - looking forward to it! Just make sure to check CONTRIBUTING.md - thanks!

@datatalking
Copy link

In a similar vein is there a way you could set the row height to be 150% so its a percentage of the font size, that way it will adjust for us and we could do either % or total pixel size so we don't have to futz with the settings except once.

Screen Shot 2023-02-03 at 9 24 18 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants