Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI to run test checks on ALL commits? #602

Open
kdmukai opened this issue Sep 5, 2024 · 0 comments
Open

Change CI to run test checks on ALL commits? #602

kdmukai opened this issue Sep 5, 2024 · 0 comments

Comments

@kdmukai
Copy link
Contributor

kdmukai commented Sep 5, 2024

cc: @dbast

Our current repo only runs the CI test suite check on PR updates and merges to dev or main.

But there should be no difference if it's changed to run on ALL commits because dev and main only ever see PR merges. Only @newtonick and @SeedSigner have permissions to push commits but Nick makes his changes in his own fork and SeedSigner (the man) is not an active dev anymore (obv he's still a key participant in other ways).

Background

I want my SeedSigner fork to kick off the CI test suite checks on EVERY commit for ANY branch.

I'm a Github Actions noob, but successfully made this change in one of my branches:

https://github.com/kdmukai/seedsigner/commits/local_kdmukai_ci/

But it occurs to me that I'd need to have this mod in all of my branches to get this desired behavior. But then it'll be a mess to pull that CI yaml change out before PRing a branch upstream.

As I thought this through, I landed at the reasoning at the very top: Just enable CI test checks on every commit. Zero actual impact on the upstream repo, more feedback for devs working in their forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant