Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pT5 r-z chi2 cut definition study based on helix approximation #410

Closed
wants to merge 2 commits into from

Conversation

YonsiG
Copy link
Contributor

@YonsiG YonsiG commented Jun 11, 2024

The original pT5 rz chi2 cut is based on linear approximation. This PR updates the trajectory estimation as a helix, the helix does not necessarily need to start from the origin. However, it still takes the pixel information as input momentum and initial point.
After this update, the pT5 efficiency in transition region is significantly improved. While also, the fake rate is reduced.

@YonsiG
Copy link
Contributor Author

YonsiG commented Jun 11, 2024

/run standalone
/run CMSSW

Copy link

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     44.1    321.6    123.6     47.7     95.3    493.4    133.5    156.7    100.5      2.4    1518.7     981.2+/- 264.1     412.5   explicit_cache[s=4] (master)
   avg     44.1    323.2    123.6     48.8     96.5    501.8    119.5    161.0    100.1      2.5    1521.0     975.1+/- 259.1     416.2   explicit_cache[s=4] (this PR)

Copy link

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@VourMa
Copy link
Contributor

VourMa commented Jun 24, 2024

Superseded by SegmentLinking/cmssw#40

@VourMa VourMa closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants