[🚀 Feature]: Support minReplicaCount and idleReplicaCount on autoscaling of type deployment

[williamlac]

Feature and motivation

Currently there is no way to set the minimum amount of replicas you want when you have the flag autoscaling.scalingType set to deployment.

So it defaults to 1 replica. I would like to set mine to have at least 3 replicas always running. Even when there is no load.

Usage example

chromeNode:
    maxReplicaCount: 4
    minReplicaCount: 3
    idleReplicaCount: 3

This would be the ideal usage, and it would set options just like maxReplica is being done on file charts/selenium-grid/templates/chrome-node-hpa.yaml:

spec:
  maxReplicaCount: {{ .Values.chromeNode.maxReplicaCount }}

I can create a PR for it, just wanted to open the issue before and see if there are any opinions against this.

[github-actions]

@williamlac, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[williamlac]

Another option would be to enable something similar to scaledJobOptions for this type of deployment.
Like done on charts/selenium-grid/templates/chrome-node-scaledjobs.yaml

{{- with .Values.autoscaling.scaledJobOptions -}}
    {{ toYaml . | nindent 2 }}
  {{- end }}

[gerardo8al]

Hey yeah, this would help me too.

[github-actions]

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

[diemol]

Fixed via #1932
Thank you

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.