Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: We should stick to main chrome channel instead of CFT (Chrome for Testing) #2041

Closed
amardeep2006 opened this issue Dec 1, 2023 · 4 comments · Fixed by #2033

Comments

@amardeep2006
Copy link
Contributor

Feature and motivation

I am sharing my thoughts that why we should stick to existing method of Chrome installation untill there is apt-get way to install CFT.

  1. The business users use chrome so to keep it closest possible to real case scenarios. CFT may share the same source code but installation method differs so sharing my doubts.
  2. CFT is supplied without OS dependency graph just a zip. No matter how hard we try, we cannot replicate apt-get . Apt not only takes care of chrome installations but also takes care of os package compatibility.

We are already getting chrome driver from CFT endpoints which is tried tested and stable method.

We should stick with existing method for stability in my opinion untill Google provides an easy way ( e.g. ppa repo) for CFT and we are able to install via apt-get OR we have some solid reason to do so.
Please share your thoughts .

Usage example

Stability of chrome.

Copy link

github-actions bot commented Dec 1, 2023

@amardeep2006, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented Dec 1, 2023

We already moved back to the regular Chrome installation, and we will keep using it. One of the main use cases of CfT is to allow users to test with previous versions to verify regressions. Which they can also do by selecting the correct tag in our images.

@diemol diemol closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2023
@VietND96
Copy link
Member

VietND96 commented Dec 1, 2023

CfT was introduced via #2018 and very fast it was rolled back in #2033 due to the issue reported.
Of course, Chrome is installed via apt-get only in released image, however I am thinking that will reuse scripts to support user can build their own image with Chrom is downloaded from CfT, it only will be triggered via --build-arg

@VietND96 VietND96 linked a pull request Dec 1, 2023 that will close this issue
8 tasks
Copy link

github-actions bot commented Jan 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants