[🐛 Bug]: ImagePullBackOff using selenium-grid helm chart

[xdoncalvox]

What happened?

After upgrading my helm chart from 0.25.1 to 0.26.1, selenium-hub and browser-node's pod started to show ImagePullBackOff, looking into the deployment for each of them I found the image field for the pod template now shows selenium/selenium/hub instead of selenium/hub (as previously) causing the mentioned error.

Command used to start Selenium Grid with Docker (or Kubernetes)

---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: selenium-grid
  namespace: qa1
spec:
  chart:
    spec:
      chart: selenium-grid
      version: "0.26.1"
      sourceRef:
        kind: HelmRepository
        name: docker-selenium
  interval: 1h0m0s

Relevant log output

Failed to pull image "selenium/selenium/hub:4.16.1-20231208": rpc error: code = Unknown desc = failed to pull and unpack image "docker.io/selenium/selenium/hub:4.16.1-20231208": failed to resolve reference

Operating System

kubernetes

Docker Selenium version (tag or chart version)

0.26.1

[github-actions]

@xdoncalvox, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[VietND96]

Hi @xdoncalvox, recently there was a breaking change in the image name via PR #2030. Please read #2039 (comment), or #2035 (comment) or README for more details.
Probably you are using an old YAML that was created before 0.25.3

[xdoncalvox]

Thank you @VietND96 for the reply. I have now readed the comments and the readme.
I would expect that if imageRegistry is not specified in the values.yaml the default value would be used. I did not specified anything under global.seleniumGrid and still got into this error. So having to add imageRegistry is strange.

[VietND96]

Ah yes, I guess your situation would be that you took the chart values.yaml and modified something there, then you provide it via --values (-f)
However, helm strategy would always take chart values.yaml to merge with your YAML given via -f.

chart/values.yaml (0.25.3 onwards)

global:
  seleniumGrid:
    imageRegistry: selenium # default global is enabled

your_values.yaml (previous version)

chromeNode:
  imageName: selenium/node-chrome

When deploying the your old values on top of new chart version, merge strategy would render the image selenium/selenium/hub:4.16.1-20231208

          {{- $imageTag := default .Values.global.seleniumGrid.imageTag .Values.hub.imageTag }}
          {{- $imageRegistry := default .Values.global.seleniumGrid.imageRegistry .Values.hub.imageRegistry }}
          image: {{ printf "%s/%s:%s" $imageRegistry .Values.hub.imageName $imageTag }}

[VietND96]

Attach a visual for my comment above. Chart values.yaml is referring always when merging.
That is the reason for my comments

try a practice that your custom YAML file should keep override values only, for remaining no different helm will refer to default chart values

[xdoncalvox]

Thank you for the quick reply

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.