Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve dependencies locally instead of fetching them again remotely #19

Open
Edouard-chin opened this issue Jan 8, 2019 · 0 comments
Open

Resolve dependencies locally instead of fetching them again remotely #19

Edouard-chin opened this issue Jan 8, 2019 · 0 comments

Comments

@Edouard-chin
Copy link
Contributor

When writing the Gemfile_next.lock snapshot, we resolve the dependencies remotely https://github.com/Shopify/bootboot/blob/master/lib/bootboot/gemfile_next_auto_sync.rb#L56
this is unnecessary as all the gems should already have been fetched.

Resolving the dependencies locally with Bundler::Definition#resolve_with_cache https://github.com/bundler/bundler/blob/a63a39d738865665f714f179fe42dd10006da26d/lib/bundler/definition.rb#L148 will speed up the install process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Edouard-chin