Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation v2 support #24

Open
lethak opened this issue May 5, 2022 · 4 comments
Open

Federation v2 support #24

lethak opened this issue May 5, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lethak
Copy link

lethak commented May 5, 2022

Hi,

Thanks for your work, I am currently starting to build a new federation project, and looking for v2 support in PHP libs as some of my subgraphs are built upon webonyx.

Do you have any plan to support Federation v2 any time soon ?

https://www.apollographql.com/docs/federation/other-servers/
image

Thanks

@xiian xiian added enhancement New feature or request help wanted Extra attention is needed labels Jun 24, 2022
@Aeliot-Tm
Copy link

@lethak FYI: I work on it. I'm going to finish implementation this week.

https://github.com/Aeliot-Tm/apollo-federation-php/tree/implement_v2

@ldiego08
Copy link
Contributor

ldiego08 commented Aug 8, 2022

@lethak - #26 has been submitted by @Aeliot-Tm and is under review. But maybe you can give it a test run and see how it works for you?

@rsouverain
Copy link

Awesome, I plan on using/testing this in a few weeks

@smyrick
Copy link

smyrick commented Jan 12, 2023

Federation v2 support can be added incrementally so while the complicated @link can take a bit more validation code things like @tag and @override only need to be defined and be able to be added on types or fields.

I am not a PHP expert, but I have commented as ideally, we wouldn't have to wait for a library to be able to add @tag in a code-first server, but that does not seem possible today. If someone wanted to add support for those directive definitions first, that could help users use new GraphOS features like Contracts, without requiring full Fed 2 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants