Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops happen in blacklisted/disabled worlds. #250

Open
roracle opened this issue Aug 23, 2022 · 2 comments
Open

Drops happen in blacklisted/disabled worlds. #250

roracle opened this issue Aug 23, 2022 · 2 comments
Labels
Bug Report A bug that needs to be fixed.

Comments

@roracle
Copy link

roracle commented Aug 23, 2022

Description (Required)

Blacklisted worlds do not prevent drops from occurring in that world.

Steps to reproduce the Issue (Required)

Blacklist a world. Break some grass.
Disabling items in the world file doesn't prevent this from occurring either.

Expected behavior (Required)

I expect blacklisted worlds (and even disabled items in core SF world configs) to not drop the disabled items.

Server Log / Error Report

No errors. SF doesn't see this as an issue.

Environment (Required)

Paper 1.19.2 131
Didn't think CS CoreLib was still used...
SF Dev 1027 (96c873bd)
EG vDEV 78 7f9a5f6

@roracle roracle added the Bug Report A bug that needs to be fixed. label Aug 23, 2022
@gphg
Copy link

gphg commented Aug 29, 2022

See: https://github.com/TheBusyBiscuit/ExoticGarden/search?q=world-blacklist&type=code
The current world-blacklist only prevent custom bush, fruit, and three being generated on fresh chunks. It's possible to get the Slimefun ExoticGarden seeds in any world as long as it has grass and player can break it.

@roracle
Copy link
Author

roracle commented Sep 8, 2022

See: https://github.com/TheBusyBiscuit/ExoticGarden/search?q=world-blacklist&type=code The current world-blacklist only prevent custom bush, fruit, and three being generated on fresh chunks. It's possible to get the Slimefun ExoticGarden seeds in any world as long as it has grass and player can break it.

When it is disabled, that should mean disabled in every way. When running a vanilla world on the same server, it is unnatural for plugins to interfere in such a way when the items are completely unusable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report A bug that needs to be fixed.
Development

No branches or pull requests

2 participants