You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The 2.10 release doesn't use the THUMBNAIL_MEDIA_ROOT and THUMBNAIL_MEDIA_URL settings.
The bug was introduced by the changes to get_storage() in commit 7bdbd7c.
There are no tests for THUMBNAIL_MEDIA_ROOT or THUMBNAIL_MEDIA_URL otherwise this would have been flagged.
I think ThumbnailFileSystemStorage should be returned when THUMBNAIL_DEFAULT_STORAGE_ALIAS is not set for backwards compatibility. But this could also be fixed with documentation. THUMBNAIL_MEDIA_ROOT and THUMBNAIL_MEDIA_URL are respected when the easy_thumbnail storage is configured to use easy_thumbnails.storage.ThumbnailFileSystemStorage. e.g.
Side note: The demo project has the easy_thumbnails storage backend set to django.core.files.storage.FileSystemStorage but I think it should be easy_thumbnails.storage.ThumbnailFileSystemStorage so people see how the default should be configured for filesystem thumbnails.
If you give me some direction how you want to address this (docs, returning ThumbnailFileSystemStorage, or something else), I can make a PR.
The text was updated successfully, but these errors were encountered:
The 2.10 release doesn't use the
THUMBNAIL_MEDIA_ROOT
andTHUMBNAIL_MEDIA_URL
settings.The bug was introduced by the changes to
get_storage()
in commit 7bdbd7c.There are no tests for
THUMBNAIL_MEDIA_ROOT
orTHUMBNAIL_MEDIA_URL
otherwise this would have been flagged.I think
ThumbnailFileSystemStorage
should be returned whenTHUMBNAIL_DEFAULT_STORAGE_ALIAS
is not set for backwards compatibility. But this could also be fixed with documentation.THUMBNAIL_MEDIA_ROOT
andTHUMBNAIL_MEDIA_URL
are respected when the easy_thumbnail storage is configured to useeasy_thumbnails.storage.ThumbnailFileSystemStorage
. e.g.Side note: The demo project has the
easy_thumbnails
storage backend set todjango.core.files.storage.FileSystemStorage
but I think it should beeasy_thumbnails.storage.ThumbnailFileSystemStorage
so people see how the default should be configured for filesystem thumbnails.If you give me some direction how you want to address this (docs, returning
ThumbnailFileSystemStorage
, or something else), I can make a PR.The text was updated successfully, but these errors were encountered: