Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot Notation With Number #40

Open
SoftCreatR opened this issue Nov 2, 2020 · 7 comments
Open

Dot Notation With Number #40

SoftCreatR opened this issue Nov 2, 2020 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@SoftCreatR
Copy link
Owner

Test Data:

[
   "first",
   "second",
   "third",
   "forth",
   "fifth"
]

Selector:

$.2

Result (Proposal A):

--- Expected
+++ Actual
@@ @@
-'[]'
+'["third"]'

https://cburgmer.github.io/json-path-comparison/results/dot_notation_with_number.html

@SoftCreatR SoftCreatR added bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed bug Something isn't working labels Nov 2, 2020
@SoftCreatR
Copy link
Owner Author

I think, the expected result from Proposal A is questionable in this case.

@Amoldreamer
Copy link

Hey @SoftCreatR, I am new here and wanted to make some online contributions. I think I am too dumb to understand the issue here. Would you mind explaining to me what exactly is needed to be done here?

@SoftCreatR
Copy link
Owner Author

Hey,

there are two types of issues: Bugs and enhancements. While bugs are typical malfunctions that should be fixed, the enhancements I'm posting are queries, where the expected results are unclear, because multiple implementations returning multiple/different results. In this cases, I expect "Proposal A" to be the correct solution: https://github.com/cburgmer/json-path-comparison/blob/master/proposals/Proposal_A/README.md

While there's no clear consensus, these enhancements are not necessarily required, but nice to have. So, if you want to contribute, you can either try fixing the bugs (there are currently 4) or find solutions, that provide the correct results, according to Proposal A.

@Amoldreamer
Copy link

Ok, first I am trying to understand what this library is about. You have described it as "json path implementation for PHP". My understanding of it is that you are trying devise new ways or maybe creating new syntax for the easier implementation of json. Am I right?

@SoftCreatR
Copy link
Owner Author

Maybe this original proposal helps you to understand, what JSONPath is: https://goessner.net/articles/JsonPath/

@Amoldreamer
Copy link

I think I now have some understanding of JSONPath and its implementation in PHP. I went through the README.md and the PHP usage. The example implementation seems to be working fine. You said that there are bugs. Where should I go about looking for bugs?

@SoftCreatR
Copy link
Owner Author

bug Something isn't working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants