feat: add id and type to match interface #164
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
| }); | ||
| } | ||
| } | ||
| } | ||
| return this.removeDuplicateSubmissionRequirementMatches(submissionRequirementMatches); | ||
| } | ||
|
|
||
| private mapMatchingDescriptors( | ||
| private getMatchingVcPatchsForSubmissionRequirement( |
There was a problem hiding this comment.
| private getMatchingVcPatchsForSubmissionRequirement( | |
| private getMatchingVcPathsForSubmissionRequirement( |
Signed-off-by: Timo Glastra <[email protected]>
|
Hey @nklomp any chance you can take a look at this PR? :) |
|
As I am on holiday, will defer to @sksadjad who should be back after the weekend, or @sanderPostma |
|
Thanks! |
|
@TimoGlastra your PRs are up next on my to do list, I expect to start after lunch, |
There was a problem hiding this comment.
looks good to me. added a few typo fixes. the part about the name of the submission_requirement.index vs input_descriptor.id I think it's a good addition. but for the whole input_descriptor.name vs input_descriptor.id I think we should drop the name and just return the id. but that is a discussion for another time.
Yeah i think that makes sense. Didn't want to remove anything for now |
Co-authored-by: sksadjad <[email protected]>
Co-authored-by: sksadjad <[email protected]>
Co-authored-by: sksadjad <[email protected]>
|
@TimoGlastra |
|
It's now pointed at fix/bugs-selection! |
sanderPostma
merged commit b8eb1d8
into
Sphereon-Opensource:fix/bugs-selection
Introduces a new
idandtypeproperty on theSubmissionRequirementMatchinterface that allows better matching of a match object to the related input_descriptor or submission_requirement.If the match is for an input descriptor (in case there are no submission_requirements) the
typeproperty will beSubmissionRequirementMatchType.InputDescriptorand theidproperty will be the id of the input descriptorI the match is for a submission requirement, the
typeproperty will beSubmissionRequirementMatchType.SubmissionRequirementand theidproperty will be the index of the submission requirement in thesubmission_requirementsarray (this is the only unique thing I could find to link back to the submission requirement entry, there is no required id field or something). This also works for nested submission requirements. In this case the outer matchidis the outer index in the submission requirement, and the inner matchidis the index within thefrom_nestedarray (this can recurse endlessly).Although adding these properties is not a breaking change, I did change the behaviour of the
nameproperty as well. Currently this was set to the name or id of one of the input descriptors, even if the match is for a submission requirement, which leads to confusion and doesn't make sense IMO. So if the match is for a submission requirement (for input descriptor behaviour stays the same) I now updated that to be either the name of the submission requirement, or undefined if there submission_requirement has no name. You can use theidproperty to locate the submission requirement associated with the match.One thing we lose here (but basically wasn't present before as well) is that you now don't know which input descriptor(s) the credentials in a submission requirement match are from. So if a group "E" can either accept a cred from input descriptor "A" or "B" you now just know that the credentials in the list match group "E", not which input descriptor they came from
I see this as a great additional feature for a follow PR (it will be non-breaking extra metadata, but should somehow be linked to the vc_paths, as there can be vcs from different input descriptors in the match list)
This fixes #116 as well as #161 (on the PEX level, there will be changes required in Credo as well)
The changes in tests mostly come from now also expecting the new properties, the change in code are quite minimal