Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: MDoc/MDL PEX validation support #165

Open
cykoder opened this issue Sep 6, 2024 · 3 comments
Open

Feature Request: MDoc/MDL PEX validation support #165

cykoder opened this issue Sep 6, 2024 · 3 comments

Comments

@cykoder
Copy link

cykoder commented Sep 6, 2024

  • I'm submitting a ...
    [ ] bug report
    [ x] feature request
    [ ] question about the decisions made in the repository
    [ ] question about how to use this project

  • Summary

Hello!

This library has been great for my PEX use cases, namely how it can verify that a presentation matches the request on the verifier side. Would this library be interested in supporting the same verification for MDoc/MDL credentials?

There are some tricky things to consider with that use case, namely what format is the input as some MDoc/MDL libs provide a different structure for the decoded and parsed credential.

  • Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

N/A

@nklomp
Copy link
Contributor

nklomp commented Sep 6, 2024

Yes we will be adding support for mdl/mdoc soon. We already have a library that can actually support mdl/mdocs with PE in kotlin multiplatform and also in its typescript export. We will probably take some of it its types/interfaces and then make a peer dep on the mdl/mdoc typescript implementation.

@nklomp
Copy link
Contributor

nklomp commented Sep 6, 2024

Btw we will probably follow iso 18013-7 as the basis, which is using PE in combination with OID4VC. In the sense that we will probably take base64url encoded issuerauth and deviceresponses as objects.

Since we also support bidirectional cose to jose conversions, I should be doable. Having said that, we will first do a direct integration into our oid4vc libs. The reason is that we already support it in our mdl/mdoc and PE for 18013-7 is so much simpler than for other credential formats, that we have chosen for this to become a 2 step process (oid4vc first, bypassing this lib for PE), then a proper integration into this lib

@cykoder
Copy link
Author

cykoder commented Sep 6, 2024

@nklomp thanks for the quick response. this all sounds great, i dont have a rigid timeline on requiring this so whenever you can get around to it is good. id be happy to help but it sounds like you guys may have all bases covered here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants