Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full website list not loading? #16

Closed
tpantpan opened this issue Aug 22, 2023 · 4 comments · Fixed by State-Channel-4/backend#19
Closed

Full website list not loading? #16

tpantpan opened this issue Aug 22, 2023 · 4 comments · Fixed by State-Channel-4/backend#19
Assignees

Comments

@tpantpan
Copy link

Was going through the C4 app to post website of the day on social and noticed that no sites that were submitted from 8/8 and onward showed up on https://app.channel4.wtf/discover

Went through 30-40 sites, so that it probabilistically unlikely to not come across any of those sites after 8/8.

Not sure if there is an issue with those sites appearing?

@tpantpan tpantpan added this to v0.3 Aug 17, 2023
@tpantpan tpantpan converted this from a draft issue Aug 22, 2023
@hackertron
Copy link
Collaborator

potential fix : #18 , gotta test.

@tpantpan
Copy link
Author

@hackertron update from 9/12 weekly call, please add any details or clarification I might have missed!

This issue is due to pagination logic. Currently, C4 loads the first 100 sites by date submitted in ascending order and randomizes that list. Once that list is complete, it loads the next 100 sites.

Because of that logic, it's uncommon for the first 100 sites to be browsed in its entirety, so the rest of the submitted sites are almost never viewed.

In the future, this logic should change to either:

  • Fetching a larger number of websites to randomize, eg: 1000
  • Selecting a random website from the existing list of sites and remove that website from the 'next website' logic

@hackertron hackertron self-assigned this Sep 20, 2023
@hackertron hackertron moved this to Todo in v0.3 Sep 20, 2023
@tpantpan
Copy link
Author

From 9/19 weekly meeting

New logic proposed by @hackertron:

  • Randomize page that will be loaded for user, eg: Page 1, 2, 3, etc.
  • Will show sites for that page
  • Randomly select new page and sites for that

TPan feedback on this: This works well for new users and if there are a lot of pages, but I'm concerned about what this would look like for returning users with a small number of pages/sites submitted.

Not sure if there is better logic to implement that is still lightweight on the dev side?

@hackertron
Copy link
Collaborator

@github-project-automation github-project-automation bot moved this from In Progress to Done in v0.3 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants