Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/navigation menu #27

Merged
merged 18 commits into from
Oct 23, 2023
Merged

Feat/navigation menu #27

merged 18 commits into from
Oct 23, 2023

Conversation

Ian-Bright
Copy link
Contributor

Implement navigation menu to resolve: #24

Note: Sign-in logic currently hardcoded until web3auth is implemented

@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for frontend-app-channel4 ready!

Name Link
🔨 Latest commit 23a7b68
🔍 Latest deploy log https://app.netlify.com/sites/frontend-app-channel4/deploys/651729f5545ab80008cb861f
😎 Deploy Preview https://deploy-preview-27--frontend-app-channel4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for frontend-app-channel4 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/frontend-app-channel4/deploys/65288527b38e8436ebaadae1
😎 Deploy Preview https://deploy-preview-27--frontend-app-channel4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ian-Bright Ian-Bright changed the base branch from main to feat/v0.3 October 5, 2023 23:20
thebeyondr
thebeyondr requested changes Oct 5, 2023
View reviewed changes
components/main-menu.tsx Show resolved Hide resolved
@thebeyondr thebeyondr added the ✨feature New feature or request label Oct 5, 2023
@Ian-Bright
Copy link
Contributor Author

Implemented the new navigation options:

Screenshot 2023-10-08 at 9 36 17 AM

there isn't a lot of space on mobile. I wonder if we could shrink the text in mobile or maybe add a scroll effect @thebeyondr ?

@thebeyondr
Copy link
Member

there isn't a lot of space on mobile. I wonder if we could shrink the text in mobile or maybe add a scroll effect @thebeyondr ?

Both maybe. Lets make the text a bit smaller and if it still overflows, add a scroll.

Also I think the options should be sentence case instead of title case. (i.e. "Choose tags" instead of "Choose Tags")

@Ian-Bright
Copy link
Contributor Author

Both maybe. Lets make the text a bit smaller and if it still overflows, add a scroll.

Also I think the options should be sentence case instead of title case. (i.e. "Choose tags" instead of "Choose Tags")

Shrunk the text padding, and margin for mobile. Think it looks pretty good.

Also changed to sentence case 🫡

@thebeyondr thebeyondr merged commit 9ae5453 into feat/v0.3 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebeyondr thebeyondr thebeyondr requested changes

Assignees

@Ian-Bright Ian-Bright

Labels
✨feature New feature or request
Projects
v0.3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.3 main navigation
2 participants
@Ian-Bright @thebeyondr