Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for DOMContentLoaded in one place #122

Open
psimonyi opened this issue Apr 4, 2013 · 4 comments
Open

Check for DOMContentLoaded in one place #122

psimonyi opened this issue Apr 4, 2013 · 4 comments

Comments

@psimonyi
Copy link
Contributor

psimonyi commented Apr 4, 2013

Right now there are several $(document).ready() things when nothing in the module actually works without the DOM. We should just wait for the DOM in main.js or something before letting those modules do anything instead of checking within each one.

@spratt
Copy link
Member

spratt commented Apr 4, 2013

Nothing in the module works without the DOM?

@psimonyi
Copy link
Contributor Author

psimonyi commented Apr 4, 2013

There are several. tutorial, for example.

@spratt
Copy link
Member

spratt commented Apr 4, 2013

I feel like I'm missing the context for that reply.

@psimonyi
Copy link
Contributor Author

psimonyi commented Apr 4, 2013

login.js also makes no sense without a DOM; all that is useful before the DOM is loaded is downloading the JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants