Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModifyField with Accordion/Tab #152

Open
Androlax2 opened this issue Jun 14, 2022 · 0 comments
Open

ModifyField with Accordion/Tab #152

Androlax2 opened this issue Jun 14, 2022 · 0 comments

Comments

@Androlax2
Copy link
Contributor

Hi,

I have made this structure with unit tests :

$builder = new FieldsBuilder('Banner');
        $builder
            ->addGroup('group')
            ->addTab('tab')
            ->addAccordion('accordion')
            ->addWysiwyg('content')
            ->addAccordion('accordion_endpoint');

        $builder
            ->modifyField('group->tab_tab->accordion_accordion', function ($builder) {
                $builder->addText('sub_title');
                return $builder;
            });

As you can see, we cannot do :

$builder
            ->modifyField('group->tab->accordion', ...)

We need to suffix tabs with _tab and accordions with _accordion.

Is this on purpose ? @stevep ? Otherwise, I can make a PR to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant