Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticky headers in PR diffs are now built-in 🎉 #16

Open
xt0rted opened this issue Mar 18, 2019 · 2 comments
Open

Sticky headers in PR diffs are now built-in 🎉 #16

xt0rted opened this issue Mar 18, 2019 · 2 comments

Comments

@xt0rted
Copy link
Member

xt0rted commented Mar 18, 2019 •
edited
Loading

https://github.blog/changelog/2019-03-18-sticky-file-headers-in-pull-requests/

Looks like they're using the class .sticky-file-header to mark these up so you'll need to adjust some of the selectors to be .file-header:not(.sticky-file-header).
@xt0rted xt0rted mentioned this issue Mar 20, 2019
Closed
@xt0rted xt0rted mentioned this issue Mar 28, 2019
Closed
@Mottie
Copy link
Member

Mottie commented Oct 22, 2019

Does this still need to be addressed? Right now, everything looks okay to me.

@xt0rted
Copy link
Member Author

xt0rted commented Oct 22, 2019

I'm not sure, I never actually used this style. From what I recall the changes that needed to be made were around removing a few of the selectors using :not() since this is built-in now and duplicate rules were being added from it.

xt0rted referenced this issue Feb 11, 2020
@xt0rted
Fix for header popup menus
39e1f4e 
Closes #20
@h1nk h1nk mentioned this issue Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mottie @xt0rted