Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline gists in Chrome #2

Open
silverwind opened this issue Jan 29, 2015 · 10 comments
Open

Inline gists in Chrome #2

silverwind opened this issue Jan 29, 2015 · 10 comments
Labels
bug 🐛 Something isn't working stylish

Comments

@silverwind
Copy link
Member

Gists in Chrome reportetly aren't styled correctly, I think @Mottie will take a look!

@silverwind silverwind added the bug 🐛 Something isn't working label Jan 29, 2015
@silverwind silverwind changed the title Chrome Gists Inline gists in Chrome Jan 29, 2015
@Mottie
Copy link
Member

Mottie commented Jan 29, 2015

I did look at it last night. I still haven't figured out why the style isn't being applied 😿

@silverwind
Copy link
Member Author

Looks like Stylish for Chrome needs to update before this kind of iframes will work:

stylish-userstyles/stylish-chrome#3

@silverwind
Copy link
Member Author

Apparently, in addition to the Stylish fix, one needs to add github.com to the 'Applies to' domain list of this style. I'm a bit afraid of doing that, as it may affect github.com, maybe there are url-based solutions?

@Mottie
Copy link
Member

Mottie commented Feb 8, 2015

I was just looking at that, I think we can point the URL to gist.github.com and gist-assets.github.com - that's the url I see in the network tab.

@silverwind
Copy link
Member Author

Indeed, that works nicely. Great find!

@silverwind
Copy link
Member Author

Damn, won't apply on a page reload, though. Might be related to stylish issue above.

@Mottie
Copy link
Member

Mottie commented Feb 8, 2015

Inline gist styling has stopped working for me :(

@silverwind
Copy link
Member Author

Inline gist styling has stopped working for me :(

on Github?

@Mottie
Copy link
Member

Mottie commented Feb 8, 2015

No, on IRCCloud.

silverwind added a commit that referenced this issue Feb 8, 2015
@silverwind
Copy link
Member Author

The current issue (if you install the git version of Stylish) is, that the gists do work if you save the style or reload the extension, but if you refresh the page the iframes aren't styled again.

Similar to what Jason encountered on MDN (stylish-userstyles/stylish-chrome#3 (comment)), but me personally, I couldn't reproduce MDN so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working stylish
Projects
None yet
Development

No branches or pull requests

2 participants