Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visited links in answers are shown dark #234

Closed
FranklinYu opened this issue Jun 26, 2021 · 3 comments
Closed

visited links in answers are shown dark #234

FranklinYu opened this issue Jun 26, 2021 · 3 comments
Labels
bug 🐛 Something isn't working

Comments

@FranklinYu
Copy link

FranklinYu commented Jun 26, 2021

Possibly affected style from Stack Exchange:

.s-prose a:not(.post-tag):not(.s-tag):not(.badge-tag):not(.s-link__visited):not(.s-btn):not(.s-editor-btn):visited,
.comment-copy a:visited {
  color:var(--theme-link-color-visited)
}

I guess we might need some !important somewhere.

Note: I enabled native dark theme in Stack Overflow, which might affect the value of --theme-link-color-visited.

@FranklinYu FranklinYu added the bug 🐛 Something isn't working label Jun 26, 2021
@the-j0k3r
Copy link
Member

the-j0k3r commented Jun 26, 2021

Would you try adding to your local install of style --theme-link-color-visited: /*[[visited-color]]*/ !important; over --theme-footer-link-color: **#aaa; in main body[class*="theme-"], body { e.g.

  body[class*="theme-"], body {
    --theme-link-color-visited: /*[[visited-color]]*/ !important;
    --theme-footer-link-color: #aaa;
    ...
    ...
    ...
    ...
}

try with and without !important I would prefer not to use it unless necessary.

Also we dont really support dark mode like you suppose, because we are not using css vars from SO, this style is much much much older than all that, and would need to be re-written which is not likely to happen in this organization with this style. If that happen Ill do own style for this, already started, but much in stackexchange is still not using css vars, so Ide like to wait on that front.

So please for best results use default so light mode together with this style, not dark mode and this style together. I also dont fancy unnecessary work to support something that is partially unknown. See #214

Let me know what result is of that new line as here I cannot reproduce your issue as my links remain same color, probably because Im blocking 3rd party cookies.

Thanks.

@the-j0k3r
Copy link
Member

the-j0k3r commented Jun 26, 2021

also please note.

.s-prose a:not(.post-tag):not(.s-tag):not(.badge-tag):not(.s-link__visited):not(.s-btn):not(.s-editor-btn), .comment-copy a { is not visited color as the exceptions :not indicate :not(.s-link__visited) etc...

At best this would be base-color

  .s-prose a:not(.post-tag):not(.s-tag):not(.badge-tag):not(.s-link__visited):not(.s-btn):not(.s-editor-btn), .comment-copy a {
    color: /*[[base-color]]*/
  }

the-j0k3r added a commit that referenced this issue Jul 5, 2021
* run clean (the-j0k3r)
* update dev deps (the-j0k3r)
* blind fix #234 (the-j0k3r)
* try style sprose code blocks color (the-j0k3r)
* update some css vars (the-j0k3r)
@FranklinYu
Copy link
Author

Hi, sorry for not replying. Yes, base-color works for me. Thank you for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants