Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider Configurations TODOs #12

Open
shriharshs opened this issue Nov 7, 2017 · 0 comments
Open

Provider Configurations TODOs #12

shriharshs opened this issue Nov 7, 2017 · 0 comments

Comments

@shriharshs
Copy link
Contributor

shriharshs commented Nov 7, 2017 •
edited
Loading

  1. Make provider configurations file name conventional.
  2. Placing the configurations file in right location (currently placed inside "bin/sms-provider")
  3. Adding active sms provider attribute to the credentials file, to pick the right sms-provider dynamically.
  4. Remove sms_base_url from configurations.
  5. Remove sms_get_url from configurations.
  6. Remove sms_post_url from configurations.
@shriharshs shriharshs changed the title Provider Configurations Provider Configurations TODOs Nov 7, 2017
shriharshs added a commit that referenced this issue Nov 9, 2017
@shriharshs
Issue #12 chores: Provider configurations refactoring, removed gateWa…
9a5584e 
…yUrl, getUrl, postUrl from config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shriharshs