Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videojs Caption Selection #21

Open
dregulae opened this issue Sep 27, 2017 · 2 comments
Open

Videojs Caption Selection #21

dregulae opened this issue Sep 27, 2017 · 2 comments

Comments

@dregulae
Copy link

Latest version of videojs some reason videojs-ass has stopped working with an error.

Uncaught (in promise) TypeError: Cannot read property 'srclang' of undefined

@SunnyLi
Copy link
Owner

SunnyLi commented Oct 13, 2017

Hi, Apology for the late response.

I haven't taken a good look at this issue yet, but I believe you can bypass the problem
if you use v0.7.0 (4548378) of videojs-ass instead of the current version v0.8.0.

Alternatively, found this pretty good fork which may have fixed the problem..

@DoomTay
Copy link
Contributor

DoomTay commented May 28, 2018

Sounds like what's happening is you need to define a srcLang for your subtitles, like so

var vjs_ass = vjs.ass({
        'src': ["subs/os.ass"],
        label: "engsub",
        srclang: "en",
        videoWidth: 640,
        videoHeight: 360,
        // enableSvg: false
      });

The docs and example URL need to be updated

But apart from that, I kinda agree that that branch handles things more intuitively than this one, with a srclang for each track and all that. The downside is that it seems to require a rather late version of video.js. That said, I'd rather features from those integrated into this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants