Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating hitboxes [HELP WANTED!] #1448

Open
Rusty-Box opened this issue Jun 24, 2020 · 13 comments
Open

Rotating hitboxes [HELP WANTED!] #1448

Rusty-Box opened this issue Jun 24, 2020 · 13 comments
Assignees
Labels
category:code help wanted involves:functionality priority:high status:assigned Developer got assigned to taks, awaiting first progress report status:needs-work In progress, but no one is currently working on it (New volunteers welcome)

Comments

@Rusty-Box
Copy link
Member

Rusty-Box commented Jun 24, 2020

Something that would be really benefitial is having rotateable hitboxes (for mechanics like swimming, swinging on ropes, rotating platforms etc.).

If you know how to do it in C++ we would be thankful for your help and support!

@Rusty-Box Rusty-Box added priority:urgent involves:functionality category:code status:needs-work In progress, but no one is currently working on it (New volunteers welcome) help wanted labels Jun 24, 2020
@Rusty-Box Rusty-Box pinned this issue Jun 24, 2020
@Rusty-Box
Copy link
Member Author

Rusty-Box commented Jun 24, 2020

Ping to our known coders, in case one of you has some knowledge to share - @tobbi @HybridDog @Zwatotem

@Zwatotem
Copy link
Member

I have my algorithms & data structures course (including geometry algorithms) semester ahead, so I don't know. I'd probably be able to do something with rectangles, but no physics.

@Zwatotem
Copy link
Member

Zwatotem commented Jul 8, 2020

What about going straight for convex polygons? Since this is an occasion for changes, maybe do it right away, and not rise similar issue in a couple months? I mean, if you can't really predict any usecase for polygon hitboxes, then we'll stay with rectangles, but otherwise I think it's worth it.

@Rusty-Box
Copy link
Member Author

@Zwatotem What would be the benefits we get through polygon hitboxes compared to rectangles?

@Zwatotem
Copy link
Member

Zwatotem commented Jul 9, 2020

I think some larger creatures object like bosses could be better modeled. Although in most cases I can think of they would require concave polygons, some things (like a large snowball featured rarely in bonus levels) gain on this undoubtly.

@HybridDog
Copy link
Contributor

HybridDog commented Jul 9, 2020

Although in most cases I can think of they would require concave polygons […]

That's probably not a problem because often those concave polygons can be decomposed into smaller convex polygons.

A polygon could be used for this spike, but it would break backwards-compatibility. I'm sometimes wondering how it is possible to get hurt by this almost 60 degree spike.
up

@Alzter
Copy link
Member

Alzter commented Jul 16, 2020

Not strictly related to polygon hitboxes, but these single sided spike tiles will hurt you from any angle. You can jump and hit your head on the wood block part of this spike and it'll hit you. On top of this spikes aren't solid blocks which is odd.

@Zwatotem Zwatotem self-assigned this Aug 12, 2020
@Zwatotem Zwatotem added the status:assigned Developer got assigned to taks, awaiting first progress report label Aug 12, 2020
@tobbi
Copy link
Member

tobbi commented Oct 18, 2023

Do you really think priority urgent is necessary here?

@Rusty-Box
Copy link
Member Author

Not anymore really. While I'd still consider it urgend to have it for stuff like swimming and, which has rotating sprites, we have functional alternative for the time being. So yes and no.

@tobbi
Copy link
Member

tobbi commented Oct 18, 2023

Better?

@tylerandari13
Copy link
Contributor

Not anymore really. While I'd still consider it urgend to have it for stuff like swimming and, which has rotating sprites, we have functional alternative for the time being. So yes and no.

Tbh i feel like swimming with a rotating hitbox would be very annoying.

@Rusty-Box
Copy link
Member Author

Don't know how since the hitbox will match Tux's actual sprite so it is even more predicatable when you get hit or not

@tylerandari13
Copy link
Contributor

Don't know how since the hitbox will match Tux's actual sprite so it is even more predicatable when you get hit or not

I guess for me it depends how Tux reacts when he turns around and his hitbox crashes into a wall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code help wanted involves:functionality priority:high status:assigned Developer got assigned to taks, awaiting first progress report status:needs-work In progress, but no one is currently working on it (New volunteers welcome)
Projects
None yet
Development

No branches or pull requests

6 participants