-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prettier Workflow run is failing for the recent PR merges #3638
Comments
fixed Prettier Formatting problem - fixes issue #3638 - short term solution
Long term solution yet to be merged! |
long term solution: Code Style GuidelinesPlease ensure your code follows the Prettier code style before submitting a Pull Request. Using Prettier
Enforce Code Style in CI: on: [push, pull_request] jobs:
|
Short Term Solution |
Hi @Honeylabh ! This looks good to me! We welcome your contribution 💯 Upon approval from other maintainers, it could be implemented! Requesting @TenTraicion , @CandidDeer and @malakada to review! |
Hii can i solve this issue? |
The Issue
As we can see in these images, Prettier Workflow run if failing for the recent PR merges. The code is not robust and not easy-to-read and this can cause linting errors.
Short term Solution
One can edit the whole
index.html
file by using the Prettier formatter and make a Pull Request to merge it.Long term Solution
Although the above solution can be a temporary fix, this problem might arrive in the future as the new Contributors come in and make a PR.
Tasks
The text was updated successfully, but these errors were encountered: