-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Bug]: Alpha version: Wallet cache hashes are different between generation and test #1103
Comments
Thanks for report @andtos90, we're looking in to it. Will keep you updated. ETA: hopefully until EOW. |
# Description Part of #157 Add Playwrigh and add the first few tests. The main goals are: - [x] Add Playwright and make it work locally - [x] Add a few tests and confirm they are working correctly (with localhost) - [x] Support connection to Metamask - [x] Add a test with API mocks, specifically for subgraph - [x] Add a test with Odoo and Wallet connection - [x] Make the API mocks typesafe - [x] Add documentation⚠️ There is an issue with how the wallet is handled after being cached for the e2e test: Synthetixio/synpress#1103 ### A few notes: I started mocking with MSW but it was a painful experience. First, Playwright doesn't work well with libraries that [override their service worker ](https://playwright.dev/docs/network#missing-network-events-and-service-workers). Then, the most promising plugin to support graphql-codegen with MSW and Playwright does not support multiple endpoints, which is an issue for testing the legacy flow (like the resolutions). In the end, I'm fairly happy with the final solution. It's not a lot of code and it doesn't use new libraries but reuses what we have without sacrificing functionalities. --------- Co-authored-by: Andrea Tosatto <[email protected]>
Facing this. |
Facing the same issue when running the example code. |
@andtos90 @vishwajeetraj11 @danielsimao could we connect on discord for further debugging, please? This issue is important for us. My discord handle is: jakubsynthetix |
Added you |
jakubsynthetix |
any work around? |
🔎 Have you searched existing issues to avoid duplicates?
🧪 Have you tested your code using latest version of Synpress?
💡 Are you able to provide enough information to be able to reproduce your issue locally?
Synpress version
4.0.0-alpha.0
Node.js version
18
Operating system
macOS Sonoma 14.1.1
Run mode
Playwright + Synpress (as plugin)
CI platform (if applicable)
No response
Are you running your tests inside docker? (if applicable)
What happened?
Not sure if you need any feedback on the alpha release, but I'll add this here and you can close it if it's something already on your radar. (Nice work, I really like the new API)
My playwright tests with Synpres don't work because I get this error inside the error trace:
The easy workaround is manually renaming the cached wallet folder from the hash generated by
synpress
to the one from the error.The internal function
getWalletSetupFuncHash
returns different values betweensynpress
andplaywright test
, I can confirm that by putting aconsole.log
after this line https://github.com/Synthetixio/synpress/blob/new-dawn/packages/core/src/defineWalletSetup.ts#L18This is the PR I'm working on: NeokingdomDAO/dapp#161
What is your expected behavior?
No response
How to reproduce the bug.
pnpm i
.env.test
to.env
pnpm e2e:init
pnpm e2e:ui
and select the testlogin just with the wallet (account in DAO)
It should fail before starting to test the real application. You can check the trace and see the error.
Relevant log output
No response
The text was updated successfully, but these errors were encountered: