Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasNewFrame can return NO from a new frame handler #54

Open
bangnoise opened this issue Dec 3, 2019 · 0 comments
Open

hasNewFrame can return NO from a new frame handler #54

bangnoise opened this issue Dec 3, 2019 · 0 comments
Assignees

Comments

@bangnoise
Copy link
Member

Sometimes the SyphonClientBase class calls the frameHandler, but the boolean "hasNewFrame" indicates there is no new frame to draw (This behaviour is logged in our client demo app) which is inconsistant

This is likely because we rely on a glFlush (the sync point for the IOSurface) after unbindAndPublish. This does mean the remote client can have the new-frame handler invoked prior to the IOSurface update being synced. In practice, it is likely (but not certain) that sync will have happened before the client actually uses the surface.

Adding this certainty would require performing the flush ourselves in unbindAndPublish - after unbinding and before publishing.

@bangnoise bangnoise self-assigned this Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant