Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Backport #3728 into release-11.5.x #3927

Open
dkd-kaehm opened this issue Jan 15, 2024 · 0 comments
Open

[TASK] Backport #3728 into release-11.5.x #3927

dkd-kaehm opened this issue Jan 15, 2024 · 0 comments

Comments

@dkd-kaehm
Copy link
Collaborator

What should be done in the scope of this task?
Backport #3728 into release-11.5.x
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue May 7, 2024
@dkd-kaehm
[BUGFIX] Cast pageType and suggestPageType to int in SearchFormViewHe…
ca92442 
…lper

Problem:
Calling the `s:searchForm` ViewHelper with the `pageType` or `suggestPageType` argument with a value from a typoscript setting will lead to a TypeError

```html
<s:searchForm pageType="{settings.pageType}" suggestPageType="{settings.suggestPageType}">
```

`TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.php`

Solution:
Cast both arguments to int

Fixes: TYPO3-Solr#3927
Ports: TYPO3-Solr#3728
@dkd-kaehm dkd-kaehm mentioned this issue May 7, 2024
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue May 7, 2024
@dkd-kaehm
[BUGFIX] Cast pageType and suggestPageType to int in SearchFormViewHe…
388851a 
…lper

Problem:
Calling the `s:searchForm` ViewHelper with the `pageType` or `suggestPageType` argument with a value from a typoscript setting will lead to a TypeError

```html
<s:searchForm pageType="{settings.pageType}" suggestPageType="{settings.suggestPageType}">
```

`TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.php`

Solution:
Cast both arguments to int

Fixes: TYPO3-Solr#3927
Ports: TYPO3-Solr#3728
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue May 7, 2024
@dkd-kaehm
[BUGFIX] Cast pageType and suggestPageType to int in SearchFormViewHe…
394528f 
…lper

Problem:
Calling the `s:searchForm` ViewHelper with the `pageType` or `suggestPageType` argument with a value from a typoscript setting will lead to a TypeError

```html
<s:searchForm pageType="{settings.pageType}" suggestPageType="{settings.suggestPageType}">
```

`TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.php`

Solution:
Cast both arguments to int

Fixes: TYPO3-Solr#3927
Ports: TYPO3-Solr#3728
dkd-kaehm added a commit that referenced this issue May 7, 2024
@dkd-kaehm
[BUGFIX] Cast pageType and suggestPageType to int in SearchFormViewHe…
970a794 
…lper

Problem:
Calling the `s:searchForm` ViewHelper with the `pageType` or `suggestPageType` argument with a value from a typoscript setting will lead to a TypeError

```html
<s:searchForm pageType="{settings.pageType}" suggestPageType="{settings.suggestPageType}">
```

`TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.php`

Solution:
Cast both arguments to int

Fixes: #3927
Ports: #3728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkd-kaehm