Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPIC] Make EXT:solr TYPO3 13 LTS compatible #3995

Open
26 of 45 tasks
dkd-kaehm opened this issue Apr 5, 2024 · 0 comments
Open
26 of 45 tasks

[EPIC] Make EXT:solr TYPO3 13 LTS compatible #3995

dkd-kaehm opened this issue Apr 5, 2024 · 0 comments
Assignees
@dkd-dobberkau @dkd-friedrich @dkd-kaehm

Comments

@dkd-kaehm
Copy link
Collaborator

dkd-kaehm commented Apr 5, 2024 •
edited
Loading

Infos and notes:

This task contains all the sub task to get EXT:solr woking within TYPO3 13 LTS:
Note: The compatibility to TYPO3 12 LTS MUST NOT be assured.

Current state of TYPO3 13 LTS support

TYPO3 13 not yet supported.

Blocker for Community Sprint 2024.05.16 + 17

Must have

Nice to have

Deprecations

  • [TASK] Remove deprecated queue.[indexConfig].table TypoScript setting

Final 13.0.0

Scheduled for same or next week of TYPO3 13 LTS stable release.

  • ...

Current State:

2024.06.10

  • Backend and indexing of all pages seemst to work properly.
  • Frontend ans Search seems to work properly
  • PhpStan issues fixed
  • Unit tests still fail
  • Integration tests still fail

2024.07.04

  • Unit tests fixed
  • Some integration tests still fail

[2024.09.17]

The translated records and pages can be indexed now.

Known issues

  • Some integration tests still fail
  • Mount-Pages and plugin.tx_solr.index.queue.[indexConfig].additionalPageIds do not work
  • Access restricted pages/records do not work
  • BE-Modules sometimes produce the BE-Links with strange id parameter, which leads to exceptions.
    typo3/module/searchbackend/index-administration?id=0_1_500_501
    Workaround: Chose desired page in tree again to get int UID again in address-bar
    Most probably new issue and analyse is required.

[2024.09.30]

The protected pages can be indexed now as well.
The BE-Modules work as expected again.

Known issues

  • Mount-Pages and plugin.tx_solr.index.queue.[indexConfig].additionalPageIds do not work
@dkd-kaehm dkd-kaehm pinned this issue Apr 5, 2024
@dkd-kaehm dkd-kaehm changed the title [EPIC] Make EXT:solr TYPO3 12 LTS compatible [EPIC] Make EXT:solr TYPO3 13 LTS compatible Apr 5, 2024
@dkd-kaehm dkd-kaehm mentioned this issue May 13, 2024
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue May 13, 2024
@dkd-kaehm
[TASK] Prepare main branch for TYPO3 13
5c6900e 
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue May 13, 2024
@dkd-kaehm
[TASK] Set Apache Solr configsets to ext_solr_13_0_0 2024.05.13
7231a71 
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue May 13, 2024
@dkd-kaehm
[TASK] Set Apache Solr configsets to ext_solr_13_0_0 2024.05.13
80d3ef9 
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue May 13, 2024
@dkd-kaehm
[BUGFIX] Fix TYPO3 coding standards
d85d4a6 
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit that referenced this issue May 13, 2024
@dkd-kaehm
[TASK] Prepare main branch for TYPO3 13
a5c6577 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 13, 2024
@dkd-kaehm
[TASK] Set Apache Solr configsets to ext_solr_13_0_0 2024.05.13
7cecf9f 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 13, 2024
@dkd-kaehm
[BUGFIX] Fix TYPO3 coding standards
a147565 
Relates: #3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue May 13, 2024
@dkd-kaehm
[TASK] Set badges in README.md properly
8ae815f 
Relates: TYPO3-Solr#3995
@dkd-kaehm dkd-kaehm mentioned this issue May 13, 2024
Merged
dkd-kaehm added a commit that referenced this issue May 13, 2024
@dkd-kaehm
[TASK] Set badges in README.md properly
75f535c 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[TASK] Prepare main branch for TYPO3 13
17c3505 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[TASK] Set Apache Solr configsets to ext_solr_13_0_0 2024.05.13
15a5385 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[BUGFIX] Fix TYPO3 coding standards
d6dac09 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[TASK] Set badges in README.md properly
10f0f26 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[TASK] Prepare main branch for TYPO3 13
a3054b0 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[TASK] Set Apache Solr configsets to ext_solr_13_0_0 2024.05.13
2f7a113 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[BUGFIX] Fix TYPO3 coding standards
33db88a 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[TASK] Set badges in README.md properly
ffd489d 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[TASK] Prepare main branch for TYPO3 13
81bb456 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[TASK] Set Apache Solr configsets to ext_solr_13_0_0 2024.05.13
76e645e 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[BUGFIX] Fix TYPO3 coding standards
ef0d460 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 16, 2024
@dkd-kaehm
[TASK] Set badges in README.md properly
fb35726 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 17, 2024
@dkd-kaehm
[TASK] Prepare main branch for TYPO3 13
a90b1d3 
Relates: #3995
dkd-kaehm added a commit that referenced this issue May 17, 2024
@dkd-kaehm
[TASK] Set Apache Solr configsets to ext_solr_13_0_0 2024.05.13
aa567bd 
Relates: #3995
@dkd-kaehm dkd-kaehm mentioned this issue Sep 24, 2024
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Sep 25, 2024
@dkd-kaehm
[BUGFIX] @typo3/backend/tree/page-tree-element does not work in BE-…
3a25449 
…Modules

This change fixes the strange behavior by switching BE-modules and/or page in page-tree.
It depends on following TYPO3 core issues:
* https://forge.typo3.org/issues/103784
* https://forge.typo3.org/issues/104457


Fixes: TYPO3-Solr#4165
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit that referenced this issue Sep 26, 2024
@dkd-kaehm
[BUGFIX] @typo3/backend/tree/page-tree-element does not work in BE-…
111f684 
…Modules

This change fixes the strange behavior by switching BE-modules and/or page in page-tree.
It depends on following TYPO3 core issues:
* https://forge.typo3.org/issues/103784
* https://forge.typo3.org/issues/104457


Fixes: #4165
Relates: #3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Sep 30, 2024
@dkd-kaehm
[FIX] access restrictions stack for TYPO3 13
12b7af9 
This change fixes the access restrictions stack within TYPO3 13.
There were multiple troubles in classes and in integration tests.
The page indexer stack on live system runs in multiple isolated processes:

1. CLI
2. first FE request to get FE-groups
3. multiple FE requests to get real content from page for desired FE-groups combination

unlike on integration test running the page indexer steps allways on single process. 
This requires to unset the produced state on each step of indexing process.
The runtime cache was interfering between the steps 
and did things that had nothing to do withhin the own step.

---

The main problem within access restriction stack on page indexing 
was the registration of Event-Listeners methods within `UserGroupDetector` with `#[AsEventListener]` on EXT:solr. 
Due of current troubles with circular dependencies 
the auto-wiring and auto-configuration was disabled in Servvices.yaml globally. 
It requires to enable this features manually for classes, which was done for `UserGroupDetector` class.

Relates: TYPO3-Solr#3995
Fixes: TYPO3-Solr#4146
@dkd-kaehm dkd-kaehm mentioned this issue Sep 30, 2024
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Sep 30, 2024
@dkd-kaehm
[FIX] access restrictions stack for TYPO3 13
d6fdfdc 
This change fixes the access restrictions stack within TYPO3 13.
There were multiple troubles in classes and in integration tests.
The page indexer stack on live system runs in multiple isolated processes:

1. CLI
2. first FE request to get FE-groups
3. multiple FE requests to get real content from page for desired FE-groups combination

unlike on integration test running the page indexer steps allways on single process. 
This requires to unset the produced state on each step of indexing process.
The runtime cache was interfering between the steps 
and did things that had nothing to do withhin the own step.

---

The main problem within access restriction stack on page indexing 
was the registration of Event-Listeners methods within `UserGroupDetector` with `#[AsEventListener]` on EXT:solr. 
Due of current troubles with circular dependencies 
the auto-wiring and auto-configuration was disabled in Servvices.yaml globally. 
It requires to enable this features manually for classes, which was done for `UserGroupDetector` class.

Relates: TYPO3-Solr#3995
Fixes: TYPO3-Solr#4161
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Sep 30, 2024
@dkd-kaehm
[FIX] #[Group('frontend')] attribute has comment in SearchControlle…
45a1e12 
…rTest

Removed comment text from `#[Group('frontend')]` attribute in 

Relates: TYPO3-Solr#3995
dkd-kaehm added a commit that referenced this issue Sep 30, 2024
@dkd-kaehm
[FIX] access restrictions stack for TYPO3 13
dc7162b 
This change fixes the access restrictions stack within TYPO3 13.
There were multiple troubles in classes and in integration tests.
The page indexer stack on live system runs in multiple isolated processes:

1. CLI
2. first FE request to get FE-groups
3. multiple FE requests to get real content from page for desired FE-groups combination

unlike on integration test running the page indexer steps allways on single process. 
This requires to unset the produced state on each step of indexing process.
The runtime cache was interfering between the steps 
and did things that had nothing to do withhin the own step.

---

The main problem within access restriction stack on page indexing 
was the registration of Event-Listeners methods within `UserGroupDetector` with `#[AsEventListener]` on EXT:solr. 
Due of current troubles with circular dependencies 
the auto-wiring and auto-configuration was disabled in Servvices.yaml globally. 
It requires to enable this features manually for classes, which was done for `UserGroupDetector` class.

Relates: #3995
Fixes: #4161
dkd-kaehm added a commit that referenced this issue Sep 30, 2024
@dkd-kaehm
[FIX] #[Group('frontend')] attribute has comment in SearchControlle…
0514886 
…rTest

Removed comment text from `#[Group('frontend')]` attribute in 

Relates: #3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 7, 2024
@dkd-kaehm
[TASK] Update solarium/solarium to 6.3.5
77a3106 
Relates: TYPO3-Solr#3995
@dkd-kaehm dkd-kaehm mentioned this issue Oct 7, 2024
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 7, 2024
@dkd-kaehm
[TASK] Update dependencies
9fbc353 
* solarium/solarium to 6.3.5
* phpunit/phpunit to 11.4+
* typo3/coding-standards to [dev-main#0d5c3c58aa773ca28eab93db6f605f8209098bd9](TYPO3/coding-standards@0d5c3c5)
* typo3/testing-framework to [dev-main#47bf0daab24b4210221f46a1fde59b9c3e245e39](TYPO3/testing-framework@47bf0da)

Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 7, 2024
@dkd-kaehm
[TASK] fix CS issues for newest typo3/coding-standards
23ffeb9 
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to TYPO3-Solr/solr-ddev-site that referenced this issue Oct 7, 2024
@dkd-kaehm
[TASK] Update dependencies
e83c689 
Relates: TYPO3-Solr/ext-solr#3995
dkd-kaehm added a commit to TYPO3-Solr/solr-ddev-site that referenced this issue Oct 7, 2024
@dkd-kaehm
[TASK] Update dependencies
73ca349 
Relates: TYPO3-Solr/ext-solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 7, 2024
@dkd-kaehm
[TASK] Update dependencies
b584e3a 
* solarium/solarium to 6.3.5
* phpunit/phpunit to 11.4+
* typo3/coding-standards to v0.8.0
* typo3/testing-framework to [dev-main#47bf0daab24b4210221f46a1fde59b9c3e245e39](TYPO3/testing-framework@47bf0da)

Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 7, 2024
@dkd-kaehm
[TASK] fix CS issues for newest typo3/coding-standards
cc0a722 
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit that referenced this issue Oct 7, 2024
@dkd-kaehm
[TASK] Update dependencies
01e5387 
* solarium/solarium to 6.3.5
* phpunit/phpunit to 11.4+
* typo3/coding-standards to v0.8.0
* typo3/testing-framework to [dev-main#47bf0daab24b4210221f46a1fde59b9c3e245e39](TYPO3/testing-framework@47bf0da)

Relates: #3995
dkd-kaehm added a commit that referenced this issue Oct 7, 2024
@dkd-kaehm
[TASK] fix CS issues for newest typo3/coding-standards
8c1e288 
Relates: #3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 7, 2024
@dkd-kaehm
[FIX] allow tags/releases from main branch
a8a8b55 
Set fixed env.BRANCH_NAME to main.

Relates: TYPO3-Solr#3995
@dkd-kaehm dkd-kaehm mentioned this issue Oct 7, 2024
Merged
dkd-kaehm added a commit that referenced this issue Oct 7, 2024
@dkd-kaehm
[FIX] allow tags/releases from main branch
26e38f8 
Set fixed env.BRANCH_NAME to main.

Relates: #3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 8, 2024
@dkd-kaehm
[TASK] migrate plugin subtype "list_type"
a37c7be 
Migrates Plugin subtypes to content elements.
See:  https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.4/Deprecation-105076-PluginContentElementAndPluginSubTypes.html#deprecation-105076-plugin-content-element-and-plugin-sub-types


Fixes: TYPO3-Solr#4180
Relates: TYPO3-Solr#3995
@dkd-kaehm dkd-kaehm mentioned this issue Oct 8, 2024
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 8, 2024
@dkd-kaehm
[TASK] migrate plugin subtype "list_type"
5ef13b1 
Migrates Plugin subtypes to content elements.
See:  https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.4/Deprecation-105076-PluginContentElementAndPluginSubTypes.html#deprecation-105076-plugin-content-element-and-plugin-sub-types


Fixes: TYPO3-Solr#4180
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 8, 2024
@dkd-kaehm
[TASK] migrate plugin subtype "list_type"
dfd3e02 
Migrates Plugin subtypes to content elements.
See:  https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.4/Deprecation-105076-PluginContentElementAndPluginSubTypes.html#deprecation-105076-plugin-content-element-and-plugin-sub-types


Fixes: TYPO3-Solr#4180
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 8, 2024
@dkd-kaehm
[TASK] migrate plugin subtype "list_type"
8591d3e 
Migrates Plugin subtypes to content elements.
See:  https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.4/Deprecation-105076-PluginContentElementAndPluginSubTypes.html#deprecation-105076-plugin-content-element-and-plugin-sub-types


Fixes: TYPO3-Solr#4180
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 9, 2024
@dkd-kaehm
[TASK] migrate plugin subtype "list_type"
b5679cb 
Migrates Plugin subtypes to content elements.
See:  https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.4/Deprecation-105076-PluginContentElementAndPluginSubTypes.html#deprecation-105076-plugin-content-element-and-plugin-sub-types


Fixes: TYPO3-Solr#4180
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 9, 2024
@dkd-kaehm
[TASK] migrate plugin subtype "list_type"
32b1c5f 
Migrates Plugin subtypes to content elements.
See:  https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.4/Deprecation-105076-PluginContentElementAndPluginSubTypes.html#deprecation-105076-plugin-content-element-and-plugin-sub-types


Fixes: TYPO3-Solr#4180
Relates: TYPO3-Solr#3995
dkd-kaehm added a commit that referenced this issue Oct 9, 2024
@dkd-kaehm
[TASK] migrate plugin subtype "list_type"
0c0f2b9 
Migrates Plugin subtypes to content elements.
See:  https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.4/Deprecation-105076-PluginContentElementAndPluginSubTypes.html#deprecation-105076-plugin-content-element-and-plugin-sub-types


Fixes: #4180
Relates: #3995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkd-dobberkau dkd-dobberkau

@dkd-friedrich dkd-friedrich

@dkd-kaehm dkd-kaehm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dkd-dobberkau @dkd-friedrich @dkd-kaehm