-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Backend summary output settings are merged #4183
Comments
@ayacoo |
OK, that is defined in Services.yaml: ext-solr/Configuration/Services.yaml Lines 53 to 61 in dc7162b
Is there a way to set DI to always deliver new instances? |
@dkd-kaehm Unfortunately, I am not aware of this DI topic. I would prefer the variant with the integration of the Content UID in the settings array. What is your opinion? Basically, this event listener integration is working. |
Preferred way is to make that class to "Data object"-Type aka non singleton. |
@bmack |
"Is there a way to set DI to always deliver new instances?" Services are shared (= same instance all the time) by default. In "classic" TYPO3-speak this is similar to SingletonInterface as we know from the past, but done in Configuration, not via a Marker interface. So, to achieve this to always get a new instance, you need to set |
@bmack thanks.
@ayacoo ;)
|
Describe the bug
If you create several result plugins on a TYPO3 page with different settings, then these settings are merged down in the backend output for the plugins and thus output incorrectly.
This file is the trigger: https://github.com/TYPO3-Solr/ext-solr/blob/main/Classes/Backend/SettingsPreviewOnPlugins.php
Here
$this->settings
is used, which would probably have to be reset with __invoke.Alternatively, you can also add an intermediate level to
$this->settings
:$this->settings[$this->pluginsTtContentRecord['uid']]
To Reproduce
Steps to reproduce the behavior:
Used versions (please complete the following information):
The text was updated successfully, but these errors were encountered: