Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-member can't reset password #411

Open
vranki opened this issue Dec 27, 2022 · 1 comment
Open

Non-member can't reset password #411

vranki opened this issue Dec 27, 2022 · 1 comment
Labels
enhancement New feature or request gui Graphical user interface, probably in WWW

Comments

@vranki
Copy link
Member

vranki commented Dec 27, 2022

A user with expired membership can try to request password reset via e-mail, but the mail is not sent. This is quite confusing UX.

I suggest if user in this situation tries to reset password, just print "Membership expired, please contact administration" so user won't get confused.

@vranki vranki added enhancement New feature or request gui Graphical user interface, probably in WWW labels Dec 27, 2022
@olmari
Copy link
Collaborator

olmari commented Dec 27, 2022

Password reset UI should not reveal anything to one way or another, it is immediate phishing vector if it reveals anything in UI as it is open to public endpoint by nature.

If no email in system at all sending email to mentioned email is also heavily discouraged, as it is abuse vector.. While not consequentially as bad as phishing, still bad practice.

If email exist but status is red, then sending mail could be justified.

Foremostly there should be figured out what has happened, or not happened, for user to find oneself in such situation one doesn't know is he/she even on the system anymore or allowed to login. Better to identify and remedy the rootcause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui Graphical user interface, probably in WWW
Projects
None yet
Development

No branches or pull requests

2 participants