Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing caption size doesn't work #9702

Open
6 tasks done
jcperil opened this issue Jan 18, 2023 · 7 comments · May be fixed by #11806
Open
6 tasks done

Changing caption size doesn't work #9702

jcperil opened this issue Jan 18, 2023 · 7 comments · May be fixed by #11806
Labels
bug Issue is related to a bug good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@jcperil
Copy link

jcperil commented Jan 18, 2023 •
edited by github-actions bot
Loading

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.24.1

Steps to reproduce the bug

  1. Settings >> Appearance >> Captions >> Caption size & style >> Text size
  2. Select Very small
  3. Return and play a video with captions
  4. Play in both normal and full screen mode.

Expected behavior

The caption size should be very small.

Actual behavior

The caption size is normal which is the default size BTW. Also, the normal size feels too large in normal mode. Most of the screen is covered by the captions.

Screenshots/Screen recordings

Caption settings

very small captions

Normal mode

normal mode

Full screen mode

full screen mode

Logs

No response

Affected Android/Custom ROM version

12

Affected device model

No response

Additional information

This issue was reported in #7986 but was abruptly closed by OP. I am not sure why as the issue still persists.
@jcperil jcperil added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jan 18, 2023
@SameenAhnaf SameenAhnaf added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) and removed needs triage Issue is not yet ready for PR authors to take up labels Jan 19, 2023
@lonewolf2208
Copy link

Hey @SameenAhnaf , can you assign this to me

@SameenAhnaf
Copy link
Collaborator

@lonewolf2208 You don't need to mention anyone. We get notifications.

@midirhee12
Copy link

midirhee12 commented Apr 12, 2023 •
edited
Loading

I have the same issue on LineageOS version 18.1 (Android v11). Has been around for quite a few versions before Newpipe 0.24.1, but I'm not exactly sure how far back.

@jcperil
Copy link
Author

jcperil commented Oct 25, 2023

My device has updated to Android 13 but the issue still persists.

@KaKi87
Copy link

KaKi87 commented Nov 22, 2023

Hi, this issue occurs all the way back to Android 6 as well. Thanks

@ShareASmile ShareASmile added the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Oct 19, 2024
@Kreiri
Copy link

Kreiri commented Nov 3, 2024

The issue is still there for me in 0.27.2. (Android 13).

@midirhee12

This comment was marked as duplicate.

Sign in to view
@Thompson3142 Thompson3142 linked a pull request Dec 20, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue is related to a bug good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix caption sizes not being changed Thompson3142/NewPipe
7 participants
@Kreiri @KaKi87 @midirhee12 @ShareASmile @lonewolf2208 @SameenAhnaf @jcperil