-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New host specific TLS contexts system is a memory hog #131
Comments
We did notice significant performance increases from this system though. There may be a middle ground possible here where we just generate a new context per connection. Some things to consider in whatever solution here include:
Disabling both may be necessary, no idea. |
Possibly use global yet ref counted host specific contexts. This may be possible by forcing down the ref count on the initial |
should be able to just do something like this: auto firstSharedPtr = {...};
auto second = firstSharedPtr;
firstSharedPtr.reset();
shared_ptr_container.emplace("hostname", std::move(firstSharedPtr));
return second; Then just do this when we find an existing elm: auto res = shared_ptr_container.find("hostname");
if(res != shared_ptr_container.end())
{
if(res->second.get() == nullptr)
{
// Needs to be created again.
}
} |
Didn't realize that TLS contexts were so memory hungry. After extended browsing, this will eat and hold forever a tremendous amount of RAM. This feature needs to be undone.
The text was updated successfully, but these errors were encountered: