Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double free inside base certificate store class #135

Open
TechnikEmpire opened this issue Oct 17, 2017 · 0 comments
Open

Double free inside base certificate store class #135

TechnikEmpire opened this issue Oct 17, 2017 · 0 comments
Assignees
Labels

Comments

@TechnikEmpire
Copy link
Owner

Because we pack the same pointers in internal storage with more than one reference (using SAN's etc for each cert), all of the contexts we store could potentially get double-free'd, and this will cause access violation as sure as you were born.

Switch internal storage to shared_ptr and don't manually delete. This will cause automatic, correct cleanup.

@TechnikEmpire TechnikEmpire self-assigned this Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant