-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "exports" in package.json ESM build #28
Comments
@userquin We provide ES6 and commonjs in the package. If you're having issues with a specific framework/build toolchain let us know. |
Checking types here https://arethetypeswrong.github.io/?p=%40mdi%2Fjs%407.3.67 Check also https://publint.dev/@mdi/[email protected] You should add package exports. |
@userquin Good call we'll add |
Just build the package, generate the tgz and upload it to first url, should be ESM in node 16 ESM. |
Thay's why I create mdi-js-es package unplugin/unplugin-auto-import#451 |
This is really needed, currently if we bundle using webpack all icons are included meaning if you just use 2 icon you still get a 3MB sized bundle of icons. |
Any idea of when the new version will be released? |
Right now we're thinking of adding... {
".": "./mdi.js",
"./*": "./glyph/*/*.js",
} This would allow |
See the PR I created, you also need to export the Typescript interface or it could not be used with moduleresolution node16 or later |
Any updates on when this will be merged in? Looking to use this and move away from MUI framework but holding us back cause of ESM support. |
Feel free to use https://github.com/userquin/mdi-js-es here, if so, I'll deprecate my package/repo.
The text was updated successfully, but these errors were encountered: