Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breadcrumb): support web component #1844

Closed
wants to merge 3 commits into from
Closed

Conversation

Lyan-u
Copy link
Collaborator

@Lyan-u Lyan-u commented Jul 20, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

TDesignOteam/tdesign-web-components#14

💡 需求背景和解决方案

📝 更新日志

  • feat(breadcrumb): support web component

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link

github-actions bot commented Jul 20, 2024

tdesign-vue preview 地址:(如果你有 DOM 变动请自行在对应技术栈仓库中发起 PR)
完成

@@ -33,7 +33,7 @@
color: @breadcrumb-icon-color-current;
}
}

:not(@{prefix}-breadcrumb-item) >
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是什么用的?

Copy link
Collaborator Author

@Lyan-u Lyan-u Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 web component 中,原来的 .t-breadcrumb__item:last-child 会选中每一个 <t-breadcrumb-item> 下的 .t-breadcrumb__item, 所以使用:not来排除web component 中的元素,后面单独处理最后一个 <t-breadcrumb-item>

@uyarn
Copy link
Collaborator

uyarn commented Jul 26, 2024

@carolin913 这个要按照前几天说的挪到_wc.less吗

@uyarn
Copy link
Collaborator

uyarn commented Dec 23, 2024

wc的额外样式不在通用部分增加了 cc @carolin913

@uyarn uyarn closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants